aminghadersohi commented on PR #38403: URL: https://github.com/apache/superset/pull/38403#issuecomment-4041793506
Thanks for the thorough review, Joe! Both items are addressed: 1. **`_resolve_viz_type` inconsistency** — Fixed to check both `show_trendline and temporal_column` (chart_utils.py:1062), matching `map_big_number_config`. 2. **`header_only` redundancy** — Removed the field entirely since it was derivable and never read in the mapper. Also removed the unreachable `return True, None` that Kamil flagged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
