rusackas commented on PR #33222: URL: https://github.com/apache/superset/pull/33222#issuecomment-4042171953
Thanks for the contribution. After reviewing the diff more carefully, there's a structural bug that would need to be addressed: the `if target_generic_type == utils.GenericDataType.BOOLEAN` block and final `return value` at the bottom of `handle_single_value` were accidentally dedented out of that nested function into the outer `filter_values_handler` scope, which would break boolean filter handling. The possible duplicate (#33230) was also closed without merging, so that concern is moot, but the underlying fix here needs another look before it would be safe to merge. Closing for now — feel free to reopen with a corrected implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
