rusackas commented on PR #33140:
URL: https://github.com/apache/superset/pull/33140#issuecomment-4043654203
The core sorting logic seems sound and the code quality is good, but two
issues need resolving:
1. Bug: unassigned items not sorted in folder-config path — sorting is
only applied in the if (!folderConfig) branch. Datasets with folder
configuration won't get alphabetical sorting for their unassigned
metrics/columns.
2. Datetime columns no longer surface first — the PR removes the existing
behavior where `is_dttm` columns float to the top. This is a meaningful UX
regression to some time-series workflows on large datasets. The was a TODO,
asking whether a feature flag is needed. I think we want to avoid feature
flags, in general, and should align on the default behavior. I'll ping some
folks here that might have feelings on this.
CC @yousoph @justinpark @kasiazjc @michael-s-molina
Minor notes:
- No test coverage for search-mode sort or the folder-config path
- Within-folder ordering is untouched (intentional, user-controlled)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
