aminghadersohi commented on code in PR #38567:
URL: https://github.com/apache/superset/pull/38567#discussion_r2927133591
##########
tests/integration_tests/thumbnails_tests.py:
##########
@@ -70,7 +70,10 @@ def test_get_async_dashboard_screenshot(self):
with patch("superset.dashboards.api.DashboardRestApi.get") as
mock_get: # noqa: F841
Review Comment:
Good catch — fixed in 2fa5dfa. Moved the list and detail endpoint fetches
before the `with patch(...)` block so the real Flask dispatch runs, and only
the thumbnail URL fetch executes against the mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]