Antonio-RiveroMartnez commented on code in PR #38606:
URL: https://github.com/apache/superset/pull/38606#discussion_r2929865083
##########
superset/config.py:
##########
@@ -311,6 +311,7 @@ def _try_json_readsha(filepath: str, length: int) -> str |
None:
"superset.views.core.explore_json",
"superset.views.core.log",
"superset.views.datasource.views.samples",
+ "flask_appbuilder.security.views.acs",
Review Comment:
Question: Why other security views don't need to be included here but this
does?
##########
superset/views/base.py:
##########
@@ -505,6 +507,16 @@ def cached_common_bootstrap_data( # pylint:
disable=unused-argument
}
)
frontend_config["AUTH_PROVIDERS"] = oauth_providers
+ elif auth_type == AUTH_SAML:
+ saml_providers = []
+ for provider in appbuilder.sm.saml_providers:
+ saml_providers.append(
+ {
+ "name": provider["name"],
+ "icon": provider.get("icon", "fa-sign-in"),
Review Comment:
nit: [FAB already
has](https://github.com/dpgaspar/Flask-AppBuilder/pull/2426/changes#diff-144718fa1ae6ddb68ced4f454e801acaf924e9276a151d8623fcdccf5a9cd474R21)
this null check, correct? so probably not needed here, also, Auth0 treats the
icon as non optional, why being different here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
