michaelmorera-preset commented on PR #38473:
URL: https://github.com/apache/superset/pull/38473#issuecomment-4054867485
The testing for this task was completed. The application is working as
expected. The color for the charts are updated when the user checks/unchecks
the "Match time shift color with original series" checkbox.
# Scenario
Verify the color is updated to match time shift color, when using the "Match
time shift color with original series" checkbox in Time Series charts.
## Variants
| Area Chart Variant| Status |
| -------- | -------- |
| 1 metric, 0 dimensions | :white_check_mark: |
| 1 metric, 1 dimensions | :white_check_mark: |
| 2+ metric, 1 dimensions | :white_check_mark: |
| 1 metric, 2+ dimensions | :white_check_mark: |
| Bar Chart Variant| Status |
| -------- | -------- |
| 1 metric, 0 dimensions | :white_check_mark: |
| 1 metric, 1 dimensions | :white_check_mark: |
| 2+ metric, 1 dimensions | :white_check_mark: |
| 1 metric, 2+ dimensions | :white_check_mark: |
| Lines Chart Variant| Status |
| -------- | -------- |
| 1 metric, 0 dimensions | :white_check_mark: |
| 1 metric, 1 dimensions | :white_check_mark: |
| 2+ metric, 1 dimensions | :white_check_mark: |
| 1 metric, 2+ dimensions | :white_check_mark: |
Note: It is important to mention that I also tested all the previous
mentioned variants with the different "Time Shift"
## Steps
1. Go to superset app
2. Create a Lines/Area/Bar chart (with a valid dataset, I used
"public.cleaned_sales_data")
3. Add the following values in the "Data" tab:
1. X-Axis (i.e. "order date").
2. Time Grain (i.e. "month").
3. Metrics (i.e. "SUM(sales)")
4. Dimensions (i.e. "deal_size")
5. Time Shift (i.e. "28 days ago")
4. Check/Uncheck the "Match time shift color with original series" checkbox
in the "Customize" tab.
## Current result
The chart lines/bars/areas colors are correctly updated to match the
original series based on if the "Match time shift color with original series"
checkbox is checked or not.
## Evidence
Updated colors for area charts
https://github.com/user-attachments/assets/1bcbe82f-d1b3-4278-80c8-a3bd790a074d
Updated colors for bar charts
https://github.com/user-attachments/assets/556405ea-517c-4f0e-b774-f747b4542e2a
Updated colors for lines chart
https://github.com/user-attachments/assets/7287e6b2-5590-4bf9-b448-2540ff660a1e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
