villebro commented on code in PR #38569:
URL: https://github.com/apache/superset/pull/38569#discussion_r2932369785
##########
tests/unit_tests/jinja_context_test.py:
##########
@@ -1693,3 +1693,24 @@ def
test_undefined_template_variable_not_function(mocker: MockerFixture) -> None
template = "SELECT {{ undefined_variable.some_method() }}"
with pytest.raises(UndefinedError):
processor.process_template(template)
+
+
[email protected](
+ ("sql", "expected"),
+ [
+ ("SELECT {{ cache_key_wrapper(abc) }}", True),
+ ("SELECT {{ cache_key_wrapper(myfunc()) }}", True),
+ ("SELECT {{ url_param('foo') }}", True),
+ ("SELECT {{ url_param(get_param('foo')) }}", True),
+ ("SELECT {{ current_user_id() }}", True),
+ ("SELECT {{ current_username() }}", True),
+ ("SELECT {{ current_user_email() }}", True),
+ ("SELECT {{ current_user_roles() }}", True),
+ ("SELECT {{ current_user_rls_rules() }}", True),
+ ("SELECT 'cache_key_wrapper(abc)' AS false_positive'", False),
Review Comment:
Thanks for catching this @EnxDev !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
