sadpandajoe commented on code in PR #38644:
URL: https://github.com/apache/superset/pull/38644#discussion_r2937373584
##########
superset-frontend/src/theme/ThemeController.ts:
##########
@@ -743,6 +747,9 @@ export class ThemeController {
return ThemeMode.DEFAULT;
}
+ // Use explicit initial mode if provided (e.g. embedded dashboards default
to light)
+ if (this.initialMode !== undefined) return this.initialMode;
Review Comment:
Good catch — added `isValidThemeMode()` validation to match the `savedMode`
check above. Also added a test for invalid `initialMode` fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
