Mayankaggarwal8055 opened a new pull request, #38680: URL: https://github.com/apache/superset/pull/38680
Fixes #38639. This PR improves the dash styles used for time-shifted derived series in ECharts timeseries charts. Previously, derived series used small generated dash patterns that could look too similar when multiple offsets were shown together, especially for comparisons like `1 year ago` and `2 years ago`. That made the lines harder to distinguish even when the colors were aligned through `timeShiftColor`. This change assigns clearer and more visible dash patterns per time offset, while keeping the pattern consistent for the same offset within the chart. ## What changed - replaced the incremental generated dash logic with a fixed set of more distinct dash patterns - mapped each time offset to a stable pattern index - preserved existing derived series opacity styling - kept compatibility with existing time-shift color behavior ## Why This makes multiple derived series easier to visually distinguish in time comparison charts without changing the intended color grouping. ## Testing - reproduced issue #38639 locally - verified the chart locally with multiple time offsets - confirmed the updated dash patterns are more visually distinct for derived series -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
