sadpandajoe commented on PR #38679: URL: https://github.com/apache/superset/pull/38679#issuecomment-4070959755
Some notes on testing. - `superset-frontend/src/theme/utils/antdTokenNames.test.ts` - wondering if we should add a test in there to validate new tokens - Do we want to have a test for partial token overrides? Example is to set maybe `bg` without a color and then validate the spread works. - PublishedLabel accepts an `onClick` prop (used by `PublishedStatus` to toggle status). The new tests don't verify click behavior at all. - Tests verify custom icon colors work, but don't assert default icon colors. E.g., physical dataset icon should default to `theme.colorPrimary`, virtual dataset icon should have no explicit color. PublishedLabel published icon should default to `theme.colorSuccess`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
