codeant-ai-for-open-source[bot] commented on code in PR #38685:
URL: https://github.com/apache/superset/pull/38685#discussion_r2944829948
##########
docker/.env:
##########
@@ -80,3 +80,7 @@ SUPERSET_SECRET_KEY=TEST_NON_DEV_SECRET
ENABLE_PLAYWRIGHT=false
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
BUILD_SUPERSET_FRONTEND_IN_DOCKER=true
+
+#new variable for timeout
+SUPERSET_WEBSERVER_TIMEOUT: 600
+GUNICORN_TIMEOUT: 600
Review Comment:
**Suggestion:** The new timeout entries use `:` instead of `=`. Docker
Compose env files require `KEY=VALUE` format, so these lines will not be parsed
as environment variables and both timeout settings will be ignored (or can
break env-file parsing). Replace them with standard `.env` assignments. [logic
error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Non-dev Docker Gunicorn timeout stays default 60 seconds.
- ⚠️ Long dashboard/query requests still terminate early.
- ⚠️ PR timeout settings in docker/.env are ignored.
```
</details>
```suggestion
SUPERSET_WEBSERVER_TIMEOUT=600
GUNICORN_TIMEOUT=600
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Use the Docker non-dev entry path defined in
`docker-compose-non-dev.yml:68`, where
service `superset` runs `"/app/docker/docker-bootstrap.sh", "app-gunicorn"`.
2. Confirm that same service loads `docker/.env` via `env_file` at
`docker-compose-non-dev.yml:47-48` (also mirrored in
`docker-compose-image-tag.yml:63`
with `env_file` at `:43-44`).
3. In `docker/.env:85-86`, timeout variables are written with `:`
(`SUPERSET_WEBSERVER_TIMEOUT: 600`, `GUNICORN_TIMEOUT: 600`) instead of `=`;
direct shell
parsing fails with `command not found` on both lines (observed from sourcing
this file).
4. Startup reaches `docker/entrypoints/run-server.sh:30`, which uses
`--timeout
${GUNICORN_TIMEOUT:-60}`; because `GUNICORN_TIMEOUT` is not set from invalid
`.env`
syntax, fallback `60` is used and the PR's intended `600` timeout is not
applied.
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docker/.env
**Line:** 85:86
**Comment:**
*Logic Error: The new timeout entries use `:` instead of `=`. Docker
Compose env files require `KEY=VALUE` format, so these lines will not be parsed
as environment variables and both timeout settings will be ignored (or can
break env-file parsing). Replace them with standard `.env` assignments.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38685&comment_hash=817831ed6351990f1a15399b82acd45960b3964ba5ed6570733b493343870582&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38685&comment_hash=817831ed6351990f1a15399b82acd45960b3964ba5ed6570733b493343870582&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
