bito-code-review[bot] commented on code in PR #38689:
URL: https://github.com/apache/superset/pull/38689#discussion_r2945880571
##########
superset/models/helpers.py:
##########
@@ -2712,9 +2712,24 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
if granularity not in self.dttm_cols and granularity is not None:
granularity = self.main_dttm_col
- columns_by_name: dict[str, "TableColumn"] = {
- col.column_name: col for col in self.columns
- }
+ columns_by_name: dict[str, "TableColumn"] = {}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Indentation error in method definition</b></div>
<div id="fix">
Line 2715 has incorrect indentation. The `columns_by_name` variable
declaration should be indented to match the method body. Fix by removing extra
leading spaces before `columns_by_name`.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
columns_by_name: dict[str, "TableColumn"] = {}
````
</div>
</details>
</div>
<small><i>Code Review Run #080364</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
