bito-code-review[bot] commented on code in PR #38690:
URL: https://github.com/apache/superset/pull/38690#discussion_r2946506971
##########
superset-extensions-cli/src/superset_extensions_cli/cli.py:
##########
@@ -824,7 +824,7 @@ def init(
else click.confirm("Include backend?", default=True)
)
- target_dir = Path.cwd() / names["id"]
+ target_dir = Path.cwd() / names["name"]
if target_dir.exists():
click.secho(f"❌ Directory {target_dir} already exists.", fg="red")
sys.exit(1)
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect directory naming breaks expected
structure</b></div>
<div id="fix">
The directory naming uses names["name"] which creates a folder like
"dashboard-widgets", but tests and documentation expect the full composite ID
like "my-org.dashboard-widgets" from names["id"]. This breaks existing test
expectations and user documentation.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
)
target_dir = Path.cwd() / names["id"]
if target_dir.exists():
click.secho(f"❌ Directory {target_dir} already exists.", fg="red")
sys.exit(1)
````
</div>
</details>
</div>
<small><i>Code Review Run #6aae35</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
