Copilot commented on code in PR #38707:
URL: https://github.com/apache/superset/pull/38707#discussion_r2955012064
##########
superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx:
##########
@@ -38,7 +38,7 @@ export function Label(props: LabelProps) {
} = props;
const baseColor = getColorVariants(theme, type);
- const color = baseColor.active;
+ const color = baseColor.text;
const borderColor = baseColor.border;
Review Comment:
This change fixes a visual regression, but current Label unit tests don't
assert the rendered text color/token. Adding a focused test that verifies the
`.ant-tag` color uses `getColorVariants(theme, type).text` (and not `.active`)
would prevent this from regressing again, especially for custom themes where
`*Text` and `*Active` differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
