kgabryje opened a new pull request, #38746:
URL: https://github.com/apache/superset/pull/38746
### SUMMARY
Followup fixes from code review of #38740:
- **DRY extraction**: Extracted duplicated `wrap_single_group_by` validator
body into shared `_normalize_group_by_input()` helper used by both
`XYChartConfig` and `MixedTimeseriesChartConfig`
- **Template fix**: Updated `chart_configs.py` resource templates to use the
new list format for `group_by` (`[{...}]` instead of `{...}`), so LLMs
consuming the resource produce correct payloads
- **Missing alias**: Added `groupby_secondary` alias to
`MixedTimeseriesChartConfig.group_by_secondary` (already had `groupby_b`, was
missing the underscore variant)
- **Test gap**: Added test for bare string `group_by="region"` input path
through `wrap_single_group_by`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — backend schema changes only.
### TESTING INSTRUCTIONS
- `pytest tests/unit_tests/mcp_service/chart/test_chart_schemas.py
tests/unit_tests/mcp_service/chart/test_new_chart_types.py
tests/unit_tests/mcp_service/chart/validation/test_column_name_normalization.py`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
