bito-code-review[bot] commented on code in PR #38695:
URL: https://github.com/apache/superset/pull/38695#discussion_r2961266288
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:
##########
@@ -201,6 +201,30 @@ function createCustomizeSection(
},
},
],
+ [
+ {
+ name: `label_position${controlSuffix}`,
+ config: {
+ type: 'SelectControl',
+ freeForm: false,
+ label: t('Label Position'),
+ choices: [
+ ['top', t('Top')],
+ ['inside', t('Inside')],
+ ['bottom', t('Bottom')],
+ ['left', t('Left')],
+ ['right', t('Right')],
+ ],
+ default: 'top',
+ renderTrigger: true,
+ description: t(
+ 'Position of the data label relative to the bar segment',
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Default label position change affects horizontal
charts</b></div>
<div id="fix">
Changing the default label position from 'auto' to 'top' alters behavior for
horizontal charts, where labels now appear at 'top' instead of 'inside' (as
'auto' would map to). This may reduce readability for horizontal bar charts. If
'auto' was removed intentionally, consider updating the default to 'inside' for
horizontal orientations or confirming this UX change is intended.
</div>
</div>
<small><i>Code Review Run #0294b9</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
