Mayankaggarwal8055 commented on code in PR #38762:
URL: https://github.com/apache/superset/pull/38762#discussion_r2966382531
##########
superset-frontend/src/dashboard/util/crossFilters.ts:
##########
@@ -98,17 +98,10 @@ export const getCrossFiltersConfiguration = (
},
};
}
- chartConfiguration[chartId].crossFilters.chartsInScope =
-
isCrossFilterScopeGlobal(chartConfiguration[chartId].crossFilters.scope)
- ? globalChartConfiguration.chartsInScope.filter(
- id => id !== Number(chartId),
- )
- : getChartIdsInFilterScope(
- chartConfiguration[chartId].crossFilters
- .scope as NativeFilterScope,
- Object.values(charts).map(chart => chart.id),
- chartLayoutItems,
- );
+ chartConfiguration[chartId].crossFilters.chartsInScope =
+ Object.values(charts)
+ .map(chart => chart.id)
+ .filter(id => id !== Number(chartId));
Review Comment:
- Removed the override that was forcing all charts into scope
- Now using getChartIdsInFilterScope with effective scope resolution (global
vs per-chart)
- Ensures existing scoped filtering behavior is preserved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
