graceguo-supercat opened a new pull request #8054: [sql lab] persist tables list in localStorage URL: https://github.com/apache/incubator-superset/pull/8054 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY In #7998 I removed some content from redux state when persist state into localStorage. Now i found tables list on the left panel is quite useful, which displayed columns name and type from tables that user previewed before. Currently when user reload sql lab from localStorage, this table list information is lost. **Solution**: Should persist this tables list into localStorage. Should persist schema and height information for sql editor instance. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before**  **After**  ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
