bito-code-review[bot] commented on code in PR #38759:
URL: https://github.com/apache/superset/pull/38759#discussion_r2967115797
##########
superset-frontend/src/components/Chart/ChartRenderer.tsx:
##########
@@ -275,10 +275,11 @@ class ChartRenderer extends Component<ChartRendererProps,
ChartRendererState> {
const nextFormData = nextProps.formData as JsonObject;
const currentFormData = this.props.formData as JsonObject;
const isMatrixifyEnabled =
- (nextFormData.matrixify_mode_rows !== undefined &&
+ nextFormData.matrixify_enable === true &&
+ ((nextFormData.matrixify_mode_rows !== undefined &&
nextFormData.matrixify_mode_rows !== 'disabled') ||
- (nextFormData.matrixify_mode_columns !== undefined &&
- nextFormData.matrixify_mode_columns !== 'disabled');
+ (nextFormData.matrixify_mode_columns !== undefined &&
+ nextFormData.matrixify_mode_columns !== 'disabled'));
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Test compatibility required</b></div>
<div id="fix">
The logic change adds a matrixify_enable check that aligns with the UI
control, but existing tests in ChartRenderer.test.tsx will fail since they
don't set this flag. Tests expecting matrixify to be enabled must include
matrixify_enable: true to maintain expected behavior.
</div>
</div>
<small><i>Code Review Run #bc913e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
