bito-code-review[bot] commented on code in PR #38705:
URL: https://github.com/apache/superset/pull/38705#discussion_r2968098022
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -1097,6 +1105,9 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
: '',
isActiveFilterValue(key, value) ? ' dt-is-active-filter' : '',
].join(' '),
+ style: resolvedTextColor
+ ? ({ color: resolvedTextColor } as CSSProperties)
+ : undefined,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Color fallback lost in styling refactor</b></div>
<div id="fix">
Change the inline style to always set the text color with fallback: `style:
{ color: resolvedTextColor || theme.colorText }`.
</div>
</div>
<small><i>Code Review Run #d6b98b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
