[GitHub] [incubator-superset] KKcorps opened a new pull request #8057: Adding support for filter box in annotations

[GitBox]

KKcorps opened a new pull request #8057: Adding support for filter box in 
annotations
URL: https://github.com/apache/incubator-superset/pull/8057
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Filter box values are now passed to the annotation layer. This resolves the 
issue when you use Time series chart as an annotation.
   Before this change, changing the time range or other filters in Filter box 
only modifying the chart but not the annotations. However, now the annotations 
are modified as well.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   **BEFORE**
   
   <img width="1663" alt="Screen Shot 2019-08-16 at 3 54 43 PM" 
src="https://user-images.githubusercontent.com/5559703/63161817-a0376100-c03e-11e9-8d39-f77f611a0c7f.png";>
   
   **AFTER**
   
   <img width="1657" alt="Screen Shot 2019-08-16 at 3 56 19 PM" 
src="https://user-images.githubusercontent.com/5559703/63161828-a6c5d880-c03e-11e9-8ac1-2453df05a587.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org