justinpark opened a new pull request, #38813: URL: https://github.com/apache/superset/pull/38813
### SUMMARY Fixes https://github.com/apache/superset/issues/38812 Bug fix: FilterableTable was using useRef to capture filterText inside a useCallback with an empty dependency array [], causing the filter to stale-close over the initial value and never re-apply when the filterText prop changed. Fixed by removing the useRef workaround and properly adding filterText to the useCallback dependency array. This commit also adds padding-bottom to the SqlLab ResultSet container to prevent the results table from being clipped at the bottom. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/user-attachments/assets/d6e57cda-e944-4807-b529-4dc4e9f20e3f <img width="1406" height="1170" alt="Screenshot 2026-03-23 at 1 00 58 PM" src="https://github.com/user-attachments/assets/61c5b468-cef8-4604-ada1-db81623d12d6"; /> After: https://github.com/user-attachments/assets/f3bd79c4-97b1-4281-8770-03c5a32a0bd6 <img width="1024" height="762" alt="Screenshot 2026-03-23 at 1 00 12 PM" src="https://github.com/user-attachments/assets/90361346-4856-4720-a834-67e25f74f9fc"; /> ### TESTING INSTRUCTIONS Added 3 unit tests to FilterableTable covering: - Shows all rows when filterText is empty - Updates filtered rows reactively when filterText prop changes - Shows all rows when filterText is cleared after filtering ### ADDITIONAL INFORMATION - [x] Has associated issue: #38812 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
