richardfogaca commented on PR #38675: URL: https://github.com/apache/superset/pull/38675#issuecomment-4119176542
@kgabryje Agreed on the DRY concern. I addressed that in the last commit by moving the shared resolution into a transform-level helper instead of Echart.tsx. I kept it out of Echart.tsx because the fallback decision needs pre-option inputs that only exist in transformProps (legendData, available width after padding/zoom offsets, and chart-specific padding application) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
