codeant-ai-for-open-source[bot] commented on PR #38845:
URL: https://github.com/apache/superset/pull/38845#issuecomment-4125874830
## **Sequence Diagram**
This PR adds two pre-write authorization checks in MCP tools. Generate
dashboard now blocks inaccessible charts, and update chart now blocks updates
when the chart dataset is inaccessible or missing.
```mermaid
sequenceDiagram
participant Client
participant MCP
participant SecurityManager
participant DatasetValidator
Client->>MCP: Call generate dashboard
MCP->>SecurityManager: Check access for requested charts
SecurityManager-->>MCP: Access result per chart
alt Any chart inaccessible
MCP-->>Client: Return access denied with chart ids
else All charts accessible
MCP-->>Client: Continue with dashboard creation flow
end
Client->>MCP: Call update chart
MCP->>DatasetValidator: Validate chart dataset access
DatasetValidator-->>MCP: Dataset validation result
alt Dataset inaccessible or missing
MCP-->>Client: Return DatasetNotAccessible error
else Dataset accessible
MCP-->>Client: Continue with chart update flow
end
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
