michael-s-molina opened a new pull request, #38846: URL: https://github.com/apache/superset/pull/38846
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The `hideTab` option in the Superset Embedded SDK's `dashboardUiConfig` was silently ignored — passing `hideTab: true` had no effect on the dashboard tab bar. **Root cause:** `DashboardBuilder.tsx` was rendering the top-level tab bar conditioned on `!uiConfig.hideNav` (bit 4) rather than `!uiConfig.hideTab` (bit 2). The `hideTab` flag was correctly parsed from the URL bitmask by `UiConfigContext` but never read anywhere in the component tree. **Fix:** Add `!uiConfig.hideTab` to the render condition in `DashboardBuilder.tsx` alongside the existing `!uiConfig.hideNav` check. This is fully backward-compatible — `hideNav` continues to suppress the tab bar as before, and `hideTab` now works as documented. ### TESTING INSTRUCTIONS 1. Set up a dashboard with top-level tabs (multiple tabs at the root level). 2. Embed the dashboard using the SDK with `dashboardUiConfig: { hideTab: true }`. 3. **Before:** Tab bar renders regardless of the flag. 4. **After:** Tab bar is hidden; only the content of the active tab is shown. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
