kgabryje commented on PR #38848: URL: https://github.com/apache/superset/pull/38848#issuecomment-4128253298
> 1. Boilerplate repetition — Every chart config class needs the same 4-line validator: > > ``` > @model_validator(mode="before") > @classmethod > def check_unknown_fields(cls, data: Any) -> Any: > return _check_unknown_fields(data, cls) > ``` > > This could be a mixin class or a shared base class. Not blocking, but if more chart types are added, it'll get repetitive. 2. AliasPath not handled — _get_known_fields handles str and AliasChoices but not AliasPath. Probably not used in these schemas today, but worth a comment or a quick isinstance(alias, AliasPath) check for robustness. good point, addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
