jaymasiwal commented on PR #38792: URL: https://github.com/apache/superset/pull/38792#issuecomment-4128906002
Hi @sadpandajoe, Duplicates: I have closed #38659. This PR (#38792) is the current version with all consolidated logic and test fixes. Screenshots & Verification: I am currently developing in a headless WSL environment and encountering 404s on static assets (service-worker.js), which is preventing the login page from rendering for a fresh capture. The Fix Verified: I have verified the fix via the DOM structure in the updated Jest tests. By switching to within(document.body).findBy..., the tests now confirm the dropdown "teleports" to the correct high-level container. If the dropdown were still constrained by the local parent (the cause of the double scrollbar), these tests would fail. Test Stability: I’ve also refactored CustomFrame.test.tsx to move the click interaction outside the waitFor loop to resolve the flakiness flagged by CodeAnt. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
