dosubot[bot] commented on issue #38854:
URL: https://github.com/apache/superset/issues/38854#issuecomment-4129066196

   <!-- Answer -->
   This appears to be related to known issues with cell content overflow in SQL 
Lab. There are a few related issues and recent fixes:
   
   **Related Issues:**
   - [#36904](https://github.com/apache/superset/issues/36904) - Cell content 
modal doesn't preserve newlines in multiline text
   - [#36042](https://github.com/apache/superset/issues/36042) - DB result cell 
collapses whitespaces (ag-Grid applies `white-space: normal` by default)
   
   **Recent Fixes:**
   - [PR #37036](https://github.com/apache/superset/pull/37036) (merged Feb 
2026) - Fixed multiline strings in cell content modals (JsonModal) by adding 
`white-space: pre-wrap`
   - [PR #38561](https://github.com/apache/superset/pull/38561) (merged Mar 
2026) - Improved SQL Lab tab layout by setting overflow to `visible`
   
   However, [PR #36090](https://github.com/apache/superset/pull/36090) which 
attempted to preserve whitespaces in ag-Grid cells was closed/abandoned, so the 
underlying cell overflow issue may still exist.
   
   The relevant code is in:
   - [`JsonModal` 
component](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/JsonModal/index.tsx#L50-L80)
 - renders JSON with `react-json-tree`
   - [`GridTable` 
component](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/GridTable/index.tsx#L148-L196)
 - contains ag-Grid styling
   
   A temporary workaround suggested in the related issues is adding custom CSS: 
`.ag-cell { white-space: pre-wrap; }`
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention 
[@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=brand-link).*
   
   ---
   <sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback/b8ad00be-ebb8-443c-9426-a1d8fa6447f2?feedback_type=great_response&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback/b8ad00be-ebb8-443c-9426-a1d8fa6447f2?feedback_type=irrelevant_answer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback/b8ad00be-ebb8-443c-9426-a1d8fa6447f2?feedback_type=incorrect_sources&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback/b8ad00be-ebb8-443c-9426-a1d8fa6447f2?feedback_type=too_verbose&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-too_verbose)
 | [Hallucination](https://app.dosu.dev/response-feedback/b8ad00be-ebb8
 
-443c-9426-a1d8fa6447f2?feedback_type=hallucination&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-hallucination)
 | [Report 
🐛](https://app.dosu.dev/response-feedback/b8ad00be-ebb8-443c-9426-a1d8fa6447f2?feedback_type=bug_report&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/b8ad00be-ebb8-443c-9426-a1d8fa6447f2?feedback_type=other&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-other)</sup>
   
   [![Chat with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=chat-badge)&nbsp;[![Open
 in 
Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=This%20appears%20to%20be%20related%20to%20known%20issues%20with%20cell%20content%20overflow%20in%20SQL%20Lab.%20There%20are%20a%20few%20related%20issues%20and%20recent%20fixes%3A%0A%0A%2A%2ARelated%20Issues%3A%2A%2A%0A-%20%5B%2336904%5D%28https%3A//github.com/apache/superset/issues/36904%29%20-%20Cell%20content%20modal%20doesn%27t%20preserve%20newlines%20in%20multiline%20text%0A-%20%5B%2336042%5D%28https%3A//github.com/apache/superset/issues/36042%29%20-%20DB%20result%20cell%20collapses%20whitespaces%20%28ag-Grid%20applies%20%60white-space%3A%20normal%60%20by%20default%29%0A%0A%2A%2ARecent%20Fixes%3A%2A%2A%0A-%20%5BPR%20%2337036%5D%28https%3A//github.com/apache/superset/pul
 
l/37036%29%20%28merged%20Feb%202026%29%20-%20Fixed%20multiline%20strings%20in%20cell%20content%20modals%20%28JsonModal%29%20by%20adding%20%60white-space%3A%20pre-wrap%60%0A-%20%5BPR%20%2338561%5D%28https%3A//github.com/apache/superset/pull/38561%29%20%28merged%20Mar%202026%29%20-%20Improved%20SQL%20Lab%20tab%20layout%20by%20setting%20overflow%20to%20%60visible%60%0A%0AHowever%2C%20%5BPR%20%2336090%5D%28https%3A//github.com/apache/superset/pull/36090%29%20which%20attempted%20to%20preserve%20whitespaces%20in%20ag-Grid%20cells%20was%20closed/abandoned%2C%20so%20the%20underlying%20cell%20overflow%20issue%20may%20still%20exist.%0A%0AThe%20relevant%20code%20is%20in%3A%0A-%20%5B%60JsonModal%60%20component%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/JsonModal/index.tsx%23L50-L80%29%20-%20renders%20JSON%20with%20%60react-json-tree%60%0A-%20%5B%60GridTable%60%20component%5D%28https%3A//github.com/apache/superset/blob
 
/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/GridTable/index.tsx%23L148-L196%29%20-%20contains%20ag-Grid%20styling%0A%0AA%20temporary%20workaround%20suggested%20in%20the%20related%20issues%20is%20adding%20custom%20CSS%3A%20%60.ag-cell%20%7B%20white-space%3A%20pre-wrap%3B%20%7D%60)&nbsp;[![Join
 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=join-discord)&nbsp;[![Share
 on 
X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/38854)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to