joaopedroab opened a new pull request, #38865: URL: https://github.com/apache/superset/pull/38865
### SUMMARY - add dashboard-scoped dynamic chart titles that resolve from dashboard native filter values - keep dynamic title customizations out of filter-bar hydration, preserve existing display-control dividers, and block overlapping dynamic-title scopes for the same chart - guard big number with trendline charts when saved form data is missing `colorPicker` - document dynamic chart titles in the dashboard docs - related discussion: https://github.com/apache/superset/discussions/34845 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF - Before: chart headers could only use the saved static chart title. - After: dashboard owners can configure a **Dynamic title** display control and render titles such as `Sales by Queensland - Australia` from native filter state. - Local validation screenshots were captured during development; no image attachments were uploaded from the CLI-generated PR. ### TESTING INSTRUCTIONS 1. Start Superset locally and open a dashboard in edit mode. 2. Open **Settings** -> **Add or edit filters and controls**, create a **Dynamic title** display control, add native filter tokens, scope it to a chart, save, and confirm the chart header updates as native filter values change. 3. Clear the referenced native filter values and confirm the chart falls back to the saved static title when the rendered template is empty. 4. Attempt to save a second dynamic title that scopes to the same chart and confirm the editor blocks the ambiguous configuration. 5. Open a dashboard with a Big Number with Trendline chart whose saved form data does not include `colorPicker` and confirm it no longer crashes. 6. Run: - `cd superset-frontend && npx jest --runInBand --silent --forceExit src/dashboard/components/nativeFilters/state.test.ts src/dashboard/util/dynamicTitle.test.ts` - `cd superset-frontend && ./node_modules/.bin/tsc -p tsconfig.json --noEmit --pretty false` - `PRE_COMMIT_HOME=/tmp/pre-commit .venv/bin/pre-commit run --all-files` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - Related discussion: https://github.com/apache/superset/discussions/34845 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
