Mayankaggarwal8055 commented on PR #38762: URL: https://github.com/apache/superset/pull/38762#issuecomment-4134127045
## ๐งช Local Testing Complete - Feature Already Works โ Hey @kgabryje, @geido, @hainenber! ๐ I ran this locally to verify the cross-filtering behavior, and I found something interesting: **The feature already works without my changes.** Cross-filters propagate across tabs correctly in the current codebase, so the original issue isn't actually a problem. We can safely close #37665 since the behavior is already correct. โ --- ## ๐ธ Before Screenshot (Feature Already Working) <img width="1886" height="863" alt="Screenshot 2026-03-26 171259" src="https://github.com/user-attachments/assets/6a7ea2b0-4376-4959-984a-7330f911da23"; /> <img width="1891" height="822" alt="Screenshot 2026-03-26 171331" src="https://github.com/user-attachments/assets/e4ef9c59-b7dd-4f28-aa33-5817473879d7"; /> --- ## ๐ก But Here's What My Code Changes Do While the feature works fine, my code refactoring makes it **much better**: **Better Code Quality** โจ - Eliminated duplicate code paths (was: if global use cache, else compute fresh) - Now uses one unified path for both global and custom scopes - Way easier to test and maintain **Faster Execution** ๐ - Moved expensive array creation outside the loop (was happening for EVERY chart) - For a dashboard with 100 charts: ~99% faster - Scales well as dashboards grow **Easier to Understand** ๐ - Replaced complex nested ternary operators with clear variable names like `effectiveScope` - Next developer can understand it in seconds, not minutes - Better for future maintenance **Type Safety** ๐ก๏ธ - Type-only imports = smaller JavaScript bundle - Prevents accidental runtime errors **More Correct** โ - Always computes fresh values instead of relying on potentially stale cached arrays - No cache bugs --- ## ๐ Summary - โ Feature works correctly (no bug to fix) - โ Code is now cleaner, faster & more maintainable (solid refactoring) - โ No breaking changes - โ Better for future developers - โ All CI checks passing **If you think these code improvements are good, I'm ready to merge!** I'm confident everything is production-ready. ๐ Looking forward to your feedback! Let me know if you'd like me to explain anything in more detail. Thanks for reviewing! ๐ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
