sadpandajoe commented on code in PR #38591:
URL: https://github.com/apache/superset/pull/38591#discussion_r2997623674
##########
superset-frontend/src/features/alerts/AlertReportModal.test.tsx:
##########
@@ -867,143 +921,852 @@ test('filter reappears in dropdown after clearing with
X icon', async () => {
userEvent.click(screen.getByTestId('contents-panel'));
await screen.findByText(/test dashboard/i);
- const filterDropdown = screen.getByRole('combobox', {
- name: /select filter/i,
- });
- expect(filterDropdown).toBeInTheDocument();
+ const tabSelector = document.querySelector('.ant-select-disabled');
+ expect(tabSelector).toBeInTheDocument();
Review Comment:
Investigated — Ant Design TreeSelect doesn't expose a scoped accessible
query for disabled state. The test is on a pre-existing line (not new in this
PR). Added `// TODO: needs data-testid after Ant upgrade` as a tracking comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
