sadpandajoe opened a new pull request, #38924:
URL: https://github.com/apache/superset/pull/38924
### SUMMARY
Promote chart, dashboard, and dataset Playwright E2E tests from
`experimental/` to stable test directories so they run as required CI blockers.
Clean up the Cypress tests they replace and remove orphaned Cypress helpers.
**What changed:**
- **Moved 9 Playwright test files** from
`tests/experimental/{chart,dashboard,dataset}/` up one level to
`tests/{chart,dashboard,dataset}/` — they are now picked up by the required
`playwright-tests` CI job (which ignores `**/experimental/**` by default)
- **Deleted 2 superseded Cypress tests**: `chart_list/list.test.ts` and
`dataset/dataset_list.test.ts`
- **Removed orphaned Cypress helpers**: `DATASET_LIST_PATH`,
`viewTypeIcons`, `setGridMode`, `toggleBulkSelect`, `interceptBulkDelete`,
`interceptDelete`, `interceptFavoriteStatus`, `setFilter` — all verified to
have zero remaining consumers
- **Kept** `tests/experimental/README.md` intact for future experimental
tests
No CI workflow changes needed — `playwright.config.ts` `testIgnore:
'**/experimental/**'` automatically includes the newly-moved files.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — no UI changes
### TESTING INSTRUCTIONS
1. `cd superset-frontend && npx playwright test --list` — verify all 27
tests listed (auth + chart + dashboard + dataset)
2. `grep -r "experimental" playwright/tests/` — only `README.md` should match
3. Cypress sharding still works: `python scripts/cypress_run.py --dry-run
--parallelism 6 --parallelism-id 0`
4. CI should run the promoted Playwright tests as required blockers
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [x] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
