michaelmorera-preset commented on PR #38886:
URL: https://github.com/apache/superset/pull/38886#issuecomment-4146318421
The testing for this task was completed. The application is working as
expected.
# Scenario
Verify the dropdown width is the correct in relation with the input field.
## Variants
| Visual Variant | Status |
| --- | --- |
| Existing dashboard - Horizontal | ✅ |
| Existing dashboard - Vertical | ✅ |
| New dashboard - Horizontal | ✅ |
| New dashboard - Vertical | ✅ |
| “Select all” / “Clear” | :warning: |
NOTE: “Select all” / “Clear” options are cut off when the user clicks on
them.
| Functional Variant | Status |
| --- | --- |
| Existing dashboard - Horizontal | ✅ |
| Existing dashboard - Vertical | ✅ |
| New dashboard - Horizontal | ✅ |
| New dashboard - Vertical | ✅ |
| “Select all” / “Clear” | ✅ |
## Steps
1. Open the Superset app and sign in with a user who can edit or view
dashboards (and the target dataset).
2. Open or create a dashboard that uses dashboard-native filters (not only
chart filters).
3. If the dashboard does not already have a multi-select filter:
1. Enter Edit mode on the dashboard.
2. Open the Filters configuration (dashboard filter bar / “Add and edit
filters”).
3. Add a filter, pick a column suitable for many values (e.g. a category
or text field from a dataset on the dashboard, similar in spirit to dimensions
on `public.cleaned_sales_data` if you use that).
4. Set the filter control type so values allow multiple selections (e.g.
multi-value / multi-select — wording depends on your Superset version: “Filter
value” with multiple values allowed, or explicit multi-select).
5. Save the filter and Save the dashboard.
4. Leave Edit mode if needed and load the dashboard so the filter bar is
visible.
5. In the filter bar, click the multi-select filter so the control is
focused and the value dropdown opens.
6. Type a few characters in the search box inside the dropdown (search that
narrows the option list, e.g. part of a known dimension value).
7. Visually compare widths: With the dropdown open (while searching is
fine), check that the dropdown panel (the floating list + search + footer) is
the same width as the filter input/trigger above it — not clearly narrower or
wider (allow a pixel or two from rounding/borders if you see something tiny).
8. Scroll if the list is long: Scroll the option list so the bottom of the
panel is visible.
9. Check that “Select all” and Clear (or your build’s equivalent labels) in
the dropdown footer are fully visible: not clipped by the panel edge, not
hidden behind scrollbars, and not overflowing outside the panel.
## Current result
After searching in the multi-select filter, the dropdown panel width matches
the filter control width, and the “Select all” / “Clear” actions in the
dropdown remain fully visible and usable (not cut off).
## Evidence
**“Select all” / “Clear”**
**Dashboard Filter**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
