aminghadersohi commented on code in PR #38934:
URL: https://github.com/apache/superset/pull/38934#discussion_r3006770407
##########
superset/mcp_service/chart/tool/generate_chart.py:
##########
@@ -744,7 +744,7 @@ async def generate_chart( # noqa: C901
chart.id,
exc_info=True,
)
- db.session.rollback()
+ db.session.rollback() # pylint:
disable=consider-using-transaction
Review Comment:
Fixed in 651ec45e51 — all inner `db.session.rollback()` calls inside `except
SQLAlchemyError` handlers are now wrapped in their own `try/except
SQLAlchemyError` so a completely broken session can't mask the graceful
fallback response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
