kgabryje commented on PR #38700:
URL: https://github.com/apache/superset/pull/38700#issuecomment-4155134040
### Code review
Found 1 issue:
1. `get_chart_sql` uses `@parse_request(GetChartSqlRequest)`, but PR #38918
("fix(mcp): remove @parse_request decorator for cleaner tool schemas", merged
2026-03-29) explicitly removed this decorator from all 19 existing MCP tools.
The reason: FastMCP 3.1 handles Pydantic `BaseModel` parameters natively, and
`@parse_request` causes degraded tool schemas (`anyOf [string, object]` instead
of a clean object schema), leading to worse LLM behavior. After #38918,
`get_chart_sql` is the only tool in the entire MCP service still using this
decorator.
https://github.com/apache/superset/blob/ceb613e733c7c86797c481bf67a25c71c537be3e/superset/mcp_service/chart/tool/get_chart_sql.py#L41-L43
https://github.com/apache/superset/blob/ceb613e733c7c86797c481bf67a25c71c537be3e/superset/mcp_service/chart/tool/get_chart_sql.py#L334-L336
🤖 Generated with [Claude Code](https://claude.ai/code)
<sub>- If this code review was useful, please react with 👍. Otherwise, react
with 👎.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
