betodealmeida commented on code in PR #37817:
URL: https://github.com/apache/superset/pull/37817#discussion_r3011811194
##########
superset/commands/explore/get.py:
##########
@@ -124,7 +124,11 @@ def run(self) -> Optional[dict[str, Any]]: # noqa: C901
security_manager.raise_for_access(datasource=datasource)
viz_type = form_data.get("viz_type")
- if not viz_type and datasource and datasource.default_endpoint:
+ if (
+ not viz_type
+ and datasource
+ and getattr(datasource, "default_endpoint", None)
Review Comment:
I know, but we should really get rid of `default_endpoint`, which is why I
decided against implementing it in the `Explorable` protocol. This is not
something that should be controlled by the datasource: it breaks expected
behavior (clicking on dataset takes you to somewhere else?) and opens security
holes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
