sadpandajoe commented on PR #38591: URL: https://github.com/apache/superset/pull/38591#issuecomment-4159693036
## Responses to latest Copilot review **Re: `React.FC` used but `React` not imported (`AlertReportList.test.tsx:38`)** `React` is already imported on line 19 via `import type React from 'react'`. This appears to be a false positive. **Re: NumberInput test should assert `"0 seconds"` instead of empty string (`NumberInput.test.tsx:57`)** The test documents the component's current behavior — `NumberInput` uses a truthiness check (`value ? ... : ''`) on line 47, which treats `0` as falsy. This is a pre-existing issue in the component (since #26202), not introduced by this PR. Fixing the component is out of scope for this test-coverage branch; a separate bug-fix PR would be the right place for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
