manojshetty2004 commented on code in PR #38657:
URL: https://github.com/apache/superset/pull/38657#discussion_r3015365945
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -962,7 +967,7 @@ export default function transformProps(
type: 'slider',
start: TIMESERIES_CONSTANTS.dataZoomStart,
end: TIMESERIES_CONSTANTS.dataZoomEnd,
- bottom: TIMESERIES_CONSTANTS.zoomBottom,
+ bottom: dynamicZoomBottom,
Review Comment:
@SBIN2010
Thanks for the suggestion! I've added a unit test to verify that the
dataZoom bottom value adjusts dynamically based on chart height. Also resolved
merge conflicts. Please let me know if anything else is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
