bito-code-review[bot] commented on code in PR #38403: URL: https://github.com/apache/superset/pull/38403#discussion_r3016312988
########## superset/mcp_service/app.py: ########## @@ -116,6 +116,8 @@ def get_default_instructions(branding: str = "Apache Superset") -> str: - chart_type="xy", kind="bar": Bar chart for category comparison - chart_type="xy", kind="area": Area chart for volume visualization - chart_type="xy", kind="scatter": Scatter plot for correlation analysis +- chart_type="big_number": Big Number display (single metric, header only) +- chart_type="big_number", show_trendline=True, temporal_column="<date_col>": Big Number with trendline (temporal_column is required when show_trendline=True) Review Comment: <!-- Bito Reply --> Yes, the instruction at line 122 in app.py now correctly includes the temporal_column parameter for big number charts with trendlines, matching the applied code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
