Copilot commented on code in PR #38929:
URL: https://github.com/apache/superset/pull/38929#discussion_r3017382822
##########
superset/db_engine_specs/doris.py:
##########
@@ -145,6 +145,53 @@ class DorisEngineSpec(MySQLEngineSpec):
"catalog": "Catalog name",
"database": "Database name",
},
+ "compatible_databases": [
+ {
+ "name": "VeloDB",
+ "description": (
+ "VeloDB is a fully-managed cloud service and enterprise "
+ "distribution built on Apache Doris. It provides real-time
"
+ "analytics and search with enterprise security and
support. "
+ "It provides SaaS and BYOC offers on AWS, GCP, and Azure."
+ ),
+ "logo": "velodb.svg",
+ "homepage_url": "https://velodb.io/";,
+ "categories": [
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.TIME_SERIES,
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.HOSTED_OPEN_SOURCE,
Review Comment:
The VeloDB entry description explicitly mentions "analytics and search", but
its `categories` omit the search category. To keep metadata consistent with the
description (and with the docs JSON change in this PR), add
`DatabaseCategory.SEARCH_NOSQL` to this list.
```suggestion
DatabaseCategory.HOSTED_OPEN_SOURCE,
DatabaseCategory.SEARCH_NOSQL,
```
##########
docs/src/data/databases.json:
##########
@@ -1700,6 +1700,46 @@
]
}
]
Review Comment:
`docs/src/data/databases.json` is invalid JSON here: there is no comma
between the `custom_errors` array and the following `compatible_databases`
property, which will break docs builds/imports that parse this file. Add the
missing comma after the closing `]` of `custom_errors`.
```suggestion
],
```
##########
superset/db_engine_specs/doris.py:
##########
@@ -145,6 +145,53 @@ class DorisEngineSpec(MySQLEngineSpec):
"catalog": "Catalog name",
"database": "Database name",
},
+ "compatible_databases": [
+ {
+ "name": "VeloDB",
+ "description": (
+ "VeloDB is a fully-managed cloud service and enterprise "
+ "distribution built on Apache Doris. It provides real-time
"
+ "analytics and search with enterprise security and
support. "
+ "It provides SaaS and BYOC offers on AWS, GCP, and Azure."
+ ),
+ "logo": "velodb.svg",
+ "homepage_url": "https://velodb.io/";,
+ "categories": [
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.TIME_SERIES,
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.HOSTED_OPEN_SOURCE,
+ ],
+ "pypi_packages": ["mysqlclient", "pydoris"],
+ "connection_string": (
+
"doris://{username}:{password}@{host}:{port}/{catalog}.{database}"
+ ),
+ "docs_url": "https://docs.velodb.io/";,
+ },
+ {
+ "name": "SelectDB",
+ "description": (
+ "SelectDB is a fully-managed cloud service and enterprise "
+ "distribution built on Apache Doris. It provides real-time
"
+ "analytics and search with enterprise security and
support. "
+ "It provides SaaS and BYOC offers on Aliyun, Tencent
Cloud, "
+ "and Huawei Cloud."
+ ),
+ "logo": "selectdb.svg",
+ "homepage_url": "https://selectdb.com/";,
+ "categories": [
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.TIME_SERIES,
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.HOSTED_OPEN_SOURCE,
+ ],
Review Comment:
The SelectDB entry description explicitly mentions "analytics and search",
but its `categories` omit the search category. To keep metadata consistent with
the description (and with the docs JSON change in this PR), add
`DatabaseCategory.SEARCH_NOSQL` to this list.
##########
docs/src/data/databases.json:
##########
@@ -1700,6 +1700,46 @@
]
}
]
+ "compatible_databases": [
+ {
+ "name": "VeloDB",
+ "description": "VeloDB is a fully-managed cloud service and
enterprise distribution built on Apache Doris. It provides real-time analytics
and search with enterprise security and support. It provides SaaS and BYOC
offers on AWS, GCP, and Azure.",
+ "logo": "velodb.svg",
+ "homepage_url": "https://velodb.io/";,
+ "categories": [
+ "ANALYTICAL_DATABASES",
+ "SEARCH_DATABASES",
+ "TIME_SERIES",
+ "CLOUD_DATA_WAREHOUSES",
+ "HOSTED_OPEN_SOURCE"
Review Comment:
The new compatible database `categories` use `SEARCH_DATABASES`, but the
docs UI category mapping (and `DatabaseCategory` in the backend) uses
`SEARCH_NOSQL`. As-is, this category will render as an unmapped raw string and
won’t group with the existing "Search & NoSQL" category. Use `SEARCH_NOSQL`
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
