dosubot[bot] commented on issue #38926: URL: https://github.com/apache/superset/issues/38926#issuecomment-4165876404
<!-- Answer --> Nice, [PR #38927](https://github.com/apache/superset/pull/38927) looks like a clean, minimal fix — removing the single `styleCache.delete?.()` line and letting the WeakMap handle cleanup via GC as intended. The change is well-scoped and the rationale is solid. Hopefully a maintainer picks it up for review soon. The fix is small enough that it should be straightforward to approve. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=brand-link).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/662d88c2-26a8-45c6-b1d6-154367ff9a48?feedback_type=great_response&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/662d88c2-26a8-45c6-b1d6-154367ff9a48?feedback_type=irrelevant_answer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/662d88c2-26a8-45c6-b1d6-154367ff9a48?feedback_type=incorrect_sources&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/662d88c2-26a8-45c6-b1d6-154367ff9a48?feedback_type=too_verbose&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/662d88c2-26a8 -45c6-b1d6-154367ff9a48?feedback_type=hallucination&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/662d88c2-26a8-45c6-b1d6-154367ff9a48?feedback_type=bug_report&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-bug_report) | [Other](https://app.dosu.dev/response-feedback/662d88c2-26a8-45c6-b1d6-154367ff9a48?feedback_type=other&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=chat-badge) [](https://cursor.com/link/prompt?text=Nice%2C%20%5BPR%20%2338927%5D%28https%3A//github.com/apache/superset/pull/38927%29%20looks%20like%20a%20clean%2C%20minimal%20fix%20%E2%80%94%20removing%20the%20single%20%60styleCache.delete%3F.%28%29%60%20line%20and%20letting%20the%20WeakMap%20handle%20cleanup%20via%20GC%20as%20intended.%20The%20change%20is%20well-scoped%20and%20the%20rationale%20is%20solid.%0A%0AHopefully%20a%20maintainer%20picks%20it%20up%20for%20review%20soon.%20The%20fix%20is%20small%20enough%20that%20it%20should%20be%20straightforward%20to%20approve.) [](https://go.dosu.dev/discord-bot?utm_source=github&ut m_medium=bot-comment&utm_campaign=github-assistant&utm_content=join-discord) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/38926) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
