bito-code-review[bot] commented on code in PR #38974: URL: https://github.com/apache/superset/pull/38974#discussion_r3021561541
########## docs/admin_docs/configuration/networking-settings.mdx: ########## @@ -64,7 +64,7 @@ There are two approaches to making dashboards publicly accessible: 3. Edit each dashboard's properties and add the "Public" role 4. Only dashboards with the Public role explicitly assigned are visible to anonymous users -See the [Public role documentation](/admin-docs/security/security#public) for more details. +See the [Public role documentation](/admin-docs/security/#public) for more details. Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Broken documentation link</b></div> <div id="fix"> The link to the Public role documentation was changed to /admin-docs/security/#public, but this breaks the link since there's no index.mdx in the security directory. Docusaurus routes require the file name for non-index files. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion See the [Public role documentation](/admin-docs/security/security#public) for more details. ```` </div> </details> </div> <small><i>Code Review Run #dfe53c</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## docs/src/pages/index.tsx: ########## @@ -717,7 +717,7 @@ export default function Home(): JSX.Element { </span> </div> <img src="/img/community/line.png" alt="line" /> - <StyledButton className="default-button-theme" href="/docs/intro"> + <StyledButton className="default-button-theme" href="/user-docs/intro"> Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect href relies on redirect</b></div> <div id="fix"> The href "/user-docs/intro" redirects to "/user-docs/" per the Docusaurus config. Since the user docs entry point is "/user-docs/", the Get Started button should link directly there instead of relying on a redirect for better UX. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion <StyledButton className="default-button-theme" href="/user-docs/"> ```` </div> </details> </div> <small><i>Code Review Run #dfe53c</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
