michael-s-molina opened a new pull request, #39009:
URL: https://github.com/apache/superset/pull/39009

   ### SUMMARY
   
   - Vertically centers the dataset editor modal using viewport-relative sizing 
(`90vh` height, `5vh` top margin) instead of a fixed pixel height, and fixes 
the centering math by removing antd's default `padding-bottom` and `margin-top` 
offsets that were adding to the effective modal height
   - Fixes resize support by moving the top offset from `.ant-modal-content` 
(which conflicted with the resizable container) to the modal root level
   - Adds spacing between the tab bar and tab panel content
   - Fixes horizontal scroll in the Settings tab caused by antd `Row` gutter 
negative margins bleeding outside the tab content area
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   
   1. Open the dataset editor modal (Edit Dataset)
   2. Verify the modal opens vertically centered with equal space above and 
below
   3. Verify the modal can be resized from the bottom and right edges
   4. Switch to the **Settings** tab and verify no horizontal scrollbar appears 
at the default modal width
   5. Verify the two-column layout in Settings stacks correctly on narrow widths
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to