etr2460 commented on a change in pull request #8058: Add docstrings and typing
to db_engine_specs and sql_parse
URL:
https://github.com/apache/incubator-superset/pull/8058#discussion_r316451230
##########
File path: superset/db_engine_specs/base.py
##########
@@ -386,37 +499,90 @@ def adjust_database_uri(cls, uri, selected_schema):
Some database drivers like presto accept '{catalog}/{schema}' in
the database component of the URL, that can be handled here.
"""
+ # TODO: All overrides mutate input uri; should be renamed or refactored
return uri
@classmethod
def patch(cls):
Review comment:
this should be `def patch(cls) -> None:` right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
