etr2460 commented on a change in pull request #8069: [SQL Lab] Async query
results serialization with MessagePack and PyArrow
URL:
https://github.com/apache/incubator-superset/pull/8069#discussion_r316453613
##########
File path: superset/__init__.py
##########
@@ -214,6 +214,7 @@ def index(self):
security_manager = appbuilder.sm
results_backend = app.config.get("RESULTS_BACKEND")
+results_backend_use_msgpack = app.config.get("RESULTS_BACKEND_USE_MSGPACK")
Review comment:
Hmm, maybe I have a misunderstanding of the semantics around making
something a `feature flag`. I understood it as gating a new feature that we
would want to roll out to 100% of users in the future. So while testing people
can enable/disable the feature, but with the expectation of in the future it
being enabled by default. Feature flags are then necessary to implement on the
frontend to support that goal, but aren't required to be both frontend and
backend changes. Maybe @mistercrunch can clarify which understanding is correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
