serenajiang opened a new pull request #8097: [fix] add checks for stopped queries URL: https://github.com/apache/incubator-superset/pull/8097 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY When a user tries to stop a query, very occasionally, the action fails and the query still runs to completion. The issue isn't user-facing, but errors in the backend show that there is some kind of lock wait timeout issue. Unknown if it is possible to completely prevent these, and the issue isn't really user-facing, but I added some tweaks to hopefully prevent a few of these conflicts. * Add `commit()` after setting the initial query status to `RUNNING` * Check if the query has stopped before running each statement. Exit if query has stopped. * (Unrelated) Removed line 281 which (afaik) doesn't do anything ### TEST PLAN Tox passes. I didn't write a test because it is pretty hard to reproduce this error - seems like a rare timing thing. These changes are mostly for safety and shouldn't affect behavior of anything. ### REVIEWERS @etr2460
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
