villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix
latest partition logic
URL:
https://github.com/apache/incubator-superset/pull/8098#discussion_r316971399
##########
File path: superset/db_engine_specs/hive.py
##########
@@ -299,16 +299,19 @@ def get_columns(
@classmethod
def where_latest_partition(cls, table_name, schema, database, qry,
columns=None):
Review comment:
This should be identical with what's in `BaseEngineSpec`:
https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs/base.py#L565-L572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
