als-sdin edited a comment on issue #6215: __init__() got an unexpected keyword 
argument 'ignore_nan'
URL: 
https://github.com/apache/incubator-superset/issues/6215#issuecomment-525592187
 
 
   Please re-open.
   I just built the latest superset from scratch following CONTRIBUTING.md and 
this bug appeared. 
   
   
![Screenshot_20190828_151838](https://user-images.githubusercontent.com/54429030/63827838-ed54f480-c9a7-11e9-8d9a-dddfafce23e4.png)
   
   I have done some investigating and found the culprit. Within 
_superset/viz.py_ the method `json_dumps` of class `BaseViz` calls `json.dumps` 
with the keyword argument `ignore_nan`. It should resolve to the **simplejson** 
package which accepts that keyword argument. Only `json.dumps` points to the 
builtin **json** library not **simplejson**.
   
   Removing the alias for **simplejson** rectifies the problem.
   
   I'm having a hard time understanding why the error occurs at all??
   
   [Link to related Pull 
Request](https://github.com/apache/incubator-superset/pull/5490)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to