villebro opened a new pull request #8136: Add duration formatter for min/sec/ms 
numeric data
URL: https://github.com/apache/incubator-superset/pull/8136
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR adds a number formatter based on 
[pretty-ms](https://www.npmjs.com/package/pretty-ms) for formatting time 
durations that was added to `superset-ui` in version 
`0.12.1`(https://github.com/apache-superset/superset-ui/pull/209). There are 
preconfigured formatters for minute, second and millisecond data, i.e.
   - `DURATION_MIN`: 66 => 1h 6m
   - `DURATION_SEC`: 66 => 1m 6s
   - `DURATION_MS`: 66000 => 1m 6s
    
   ### SCREENSHOT
   
![image](https://user-images.githubusercontent.com/33317356/63862091-b1745c00-c9b4-11e9-9898-612f57b7a45b.png)
   
   ### TEST PLAN
   Tested locally
   
   ### REVIEWERS
   @etr2460 @kristw @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to