etr2460 commented on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525967377 If you add `# noqa` then i think you should specify the rule that you're disabling. Also if it's just a missing return then you can feel free to add `return None` at the end of functions that are missing it. Also cc @villebro @mistercrunch and @michellethomas to take a look too since python isn't my strong suit
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
